-
Notifications
You must be signed in to change notification settings - Fork 2
Generalize prompt tokenizers #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelDucartier
commented
Oct 28, 2025
Co-authored-by: MichelDucartier <m.zhang2490@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and generalizes the prompt tokenization and chat formatting logic across the codebase. The main improvement is the introduction of a flexible
ChatTemplateabstraction, which supports multiple chat prompt formats (LLaMA, Apertus, Qwen, etc.) and is now integrated into thePromptTokenizer. This update removes the need for model-specific tokenizers and simplifies configuration, making it easier to add support for new chat formats.Key changes:
Chat template abstraction and integration:
ChatTemplatedataclass inmodel.py, which encapsulates chat serialization logic for various LLM families (LLaMA, Apertus, Qwen3) and provides a unified interface for formatting conversations. (src/multimeditron/model/model.py)PromptTokenizerto accept aChatTemplateinstance, removing hardcoded logic for specific models and enabling dynamic chat prompt formatting. (src/multimeditron/model/prompt_tokenizers.py) [1] [2]Removal of model-specific tokenizers:
Llama3PromptTokenizerand theTOKENIZER_MAPindirection, consolidating all prompt tokenization logic into the generalizedPromptTokenizerclass. (src/multimeditron/model/prompt_tokenizers.py,src/multimeditron/dataset/sample_preprocessor.py,scripts/benchmarking.py) [1] [2]API and code modernization:
PromptTokenizerthroughout the codebase to pass the appropriateChatTemplate(usingChatTemplate.from_name). (scripts/benchmarking.py,src/multimeditron/dataset/sample_preprocessor.py) [1] [2]src/multimeditron/model/prompt_tokenizers.py) [1] [2] [3] [4] [5] [6] [7] [8]These changes make the codebase more modular, extensible, and easier to maintain as new chat prompt formats emerge.