refactor: properly support "empty" StAX element#44
Conversation
|
Hello. I cloned this branch to try to test it. After the clone, in the exificient dir, I tried "mvn install" to build and install the new version into my mvn repo so I could then, hopefully, try to use it in place of the release version, as a dependency (I'm a more than a bit of a novice to mvn, but trying to figure it out). It appears to me that mvn encountered a build error - also, it appears that github is also reporting build errors (I see an error above, on this page "1 failing check". So, I don't think I can test this, because it's not buildable. My local maven gave this error: UPDATE: Well, I figured out that I can skip the tests with: UPDATE 2: So, as I mentioned on the other ticket, I was under the mistaken impression I was cloning directly to the issue-43 branch. Turns out I cloned to the 'main' branch, and had to switch locally to the issue-43 branch and rebuild exificient to test the fix. Sorry, it's been awhile since I used git/github with branches. I got it sorted in the end though. But, it appears even the issue-43 branch also gets the test errors, so I still had to force mvn to skip the tests to install and test it. But, my test was a success, and passed. |
|
Your lasted "update" means it is working as expected, right? |
|
@danielpeintner - yes, that's right. Sorry about the confusion. |
fixes #43