Skip to content

Server & Workiversaries#2

Open
ashtonmeuser wants to merge 7 commits intomasterfrom
task-0001-node-server
Open

Server & Workiversaries#2
ashtonmeuser wants to merge 7 commits intomasterfrom
task-0001-node-server

Conversation

@ashtonmeuser
Copy link

Download from Google Sheets
Add server with /month and /today endpoints
Calculate workiversaries from Sheets data

package.json Outdated
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"dayjs": "^1.8.21",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock

server.js Outdated
reportingDates, employeeFromRow, workiversariesByDates, workiversariesByMonth,
} = require('./workiversaries.js');

const sheetId = '1aJOtfVhFacpWEpKifFzKegI0x49_rqbhiR0o3fPwneg';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be comitted

server.js Outdated
@@ -0,0 +1,32 @@
const express = require('express');
const { getSheetContent } = require('./sheets.js');
const {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into es6 imports

Copy link

@mmumby mmumby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mmumby
Copy link

mmumby commented Mar 13, 2020

For some reason, I only saw one of Adams comments before approving. Let's add the sheet Id to an env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants