[#9] YAML 수정 & Swagger 설정 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bucoco
requested review from
damiiya,
haribonyam,
jaewonLeeKOR and
manbron236
Member
jaewonLeeKOR
left a comment
jaewonLeeKOR
left a comment
There was a problem hiding this comment.
VPN을 통해 내부망에서 dns나 ip로 접근은 가능하게 하면서 퍼블릭 DNS로의 접근시에는 사용을 하지 못하도록 막는것이 좋을것같습니다.
이부분은 혹시 고려가 된건가요?
Collaborator
Author
게이트웨이의 퍼블릭 DNS는 고려하지 못했습니다. 가능하다면 VPN 내에서만 접근할 수 있게 수정하겠습니다 |
- 허가된 호스트만 swagger에 접근가능하게 filter 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 구현/변경 사항
🧪 테스트 결과
참고
closes #9