Skip to content

Issue #9: Failing test on master branch #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jelaniharris wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #9: Failing test on master branch #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/module/authentication/store/auth-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,11 @@ export class AuthStore {
},
method: "POST",
});

this.clearAll();
return true;
} catch (error) {
// If we weren't able to handle the error, then indicate that something unexpected
// If we weren't able to handle the error, then indicate that something unexpected happened
if (!this.handleError(error)) {
this.updateErrorField("emailError", "An unknown error occurred resetting email.");
}
Expand Down Expand Up @@ -261,7 +262,9 @@ export class AuthStore {

return true;
} catch (error) {
this.handleError(error);
if (!this.handleError(error)) {
this.updateErrorField("passwordError", "Log in failed.");
}
return false;
}
}
Expand Down Expand Up @@ -358,8 +361,6 @@ export class AuthStore {
parsedError = true;
break;
default:
this.updateErrorField("passwordError", "Log in failed.");
parsedError = true;
break;
}
}
Expand Down