Skip to content

local prod fix #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheJeran merged 1 commit into from
Mar 2, 2026
Merged

local prod fix #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion next.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path from 'path';
const isProd = process.env.NODE_ENV === 'production';
const basePath = isProd ? (process.env.BASE_PATH || '') : '';
// const targetFolder = process.env.TARGET_FOLDER || '';
const assetPrefix = isProd ? (basePath ? `${basePath.replace(/\/$/, '')}/` : './') : '';
const assetPrefix = isProd ? (basePath ? `${basePath.replace(/\/$/, '')}/` : '') : '';

/** @type {import('next').NextConfig} */
const nextConfig = {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/MainPanel/LocalNetCDF.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const LocalNetCDF = ({ setOpenVariables}:LocalNCType) => {
data.getFullMetadata()
])
useGlobalStore.setState({variables: Object.keys(variables), zMeta: metadata, initStore:`local_${file.name}`})
useZarrStore.setState({useNC: true, ncModule: data})
useZarrStore.setState({ fetchNC:true, useNC: true, ncModule: data})
Copy link

@gemini-code-assist gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While setting fetchNC: true here fixes the issue, you've raised a good point in the PR description about unifying the logic for fetchNC and useNC. To improve maintainability and prevent inconsistent states, you could encapsulate this logic in a dedicated action within your ZarrStore.

For example, an action like setNetCDFModule(data) could handle setting ncModule, useNC, and fetchNC together:

// In ZarrStore.ts
setNetCDFModule: (data) => set({ ncModule: data, useNC: !!data, fetchNC: !!data })

// In LocalNetCDF.tsx
// Then you could call it like this, replacing the current setState call:
useZarrStore.getState().setNetCDFModule(data)

This would centralize the state transition logic, making it more robust and easier to reason about. This would require changes in ZarrStore.ts.

const titleDescription = {
title: attrs.title?? file.name,
description: attrs.history?? ''
Expand Down
Loading