Update pilot panel settings and reduce still image resolution #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made on June 4th to get the ROV up and running with the Panel. Note: The master branch is stable again after this change
There was a bug in the profile code where I had short clicks performing the profile save, and had long clicks performing the profile switch. I was also not filtering for just release clicks. This has been fixed. Further, I added some flashing when the profile gets saved * blink blink blink *
All the sliders are upside down compared to last year, so I added a method to flip the power from
(0, 1)value range to(1, 0).I also removed the 1080p resolution stream as the base for the
picameras. I thought that theresizeblock in theH264pipeline performed resizing through sampling, but it looks like it just truncates the edges of the image. This reduces our FOV by a lot, so it's not acceptable. The stills captured by the python script are still better quality than theH264frames captured by the stream decoder, so it is not a complete loss. Perhaps there is a high quality4:3resolution that could be truncated without losing much FOV on the horizontal axis?