-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor the io package and create depth sensor. #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
edits Added a line to the startup command which enables remote debugging. This can be done through intellij or eclipse and let the user debug the pi remotely in their IDE. I don't know why I only just added this... I've used this tool many times in the past. |
…rometer less specific
… thermometer less specific
Contributor
Author
|
Edits:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the project has expanded the
iopackage has become larger and larger. This PR attempts to re-package theioclasses to make more sense. New sub-packages have been created for this purpose.A generic
io.devicespackage has been created to hold onto all of the interfaces implemented by theiopackage. Further, theBarometerandThermometerclasses have been refactored to usePressureValue/TemperatureValueinterfaces instead ofInternalPressureValue/TemperaturePressureValue. This means that no new device interface had to be created to make the newBar30PressureSensor(which reads pressure and temperature). Continuing this change, the same package has been created under test to hold onto the mock classes.During this cleanup I also removed a lot of the sensors that we don't use anymore such as the LM35, TMP36, and MPX4250AP.
The panel controllers (
EmergencyStopController,MotionPowerStoreController,SliderController) have been moved to apanelpackage and their dependency on the Arduino has been removed.Arduinonow implements theBoardIOinterface which is in thedevicespackage.The
rpipackage was created to hold onto Raspberry Pi specific code. In the future it would be good to limit all the pi4j dependencies to this folder to help make more of the code readily testable.The
Bar30PressureSensordepth sensor itself is now present under theiopackage and implementsPressureValueandTemperatureValue. It follows a similar pattern to the IMU and is passed to theRovas a generic value with multiple bounded type parameters.This still needs to be tested in hardware, but once that's done this should be good to go.