[WIP] Emit audit message for non-bot user modifications of managed roles

[Copilot]

• Add GuildRoleUpdate event handler to DiscordIntegrator
• Implement handler to check if modified role is a managed role (all roles in RoleMap)
• Query Discord audit log to determine who made the modification
• Filter out bot-initiated changes
• Send audit message to guild audit channel with modification details
• Include role type identification in audit messages
• Address PR review feedback (refactor role type logic, fix duplicate logging)
• Validate implementation with manual testing (requires live Discord environment)

Implementation Details:

• Monitors all managed roles: Member, Enforcer, Auditor, ServerHost, Allocator, Suspended, APIAccess, AccountAgeBypass, VPNBypass, AccountLinked (primary focus), and UsernameOnly
• Includes role type in audit messages for better clarity
• Provides detailed change information from Discord audit logs
• Skips bot-initiated changes to prevent duplicate notifications
• Refactored role type determination into reusable GetRoleType() helper method

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Emit audit message when a managed role is modified by a non-bot user</issue_title>
<issue_description>When a managed role (e.g. the linked role) within a guild is modified by anyone other than the bot, the system should emit an audit message to the guild's audit channel. This ensures that all changes to managed roles are properly tracked and can be reviewed for security and compliance purposes.

Requirements:

• Detect modifications to managed roles, specifically the linked role, within each guild.
• If the modification is performed by a user other than the bot, send an audit message to the designated audit channel for that guild.
• The audit message should include relevant details such as the user who made the change, timestamp, and details of the modification.
• Ensure the implementation does not send duplicate messages for bot-initiated changes.

Rationale:

• Provides a clear audit trail for sensitive role changes.
• Enhances transparency and accountability within guild administration.
• Improves detection of unauthorized or unexpected changes to managed roles.

Acceptance Criteria:

• Audit messages are reliably sent when non-bot users change managed roles.
• No audit messages are sent for actions performed by the bot itself.
• Audit messages contain sufficient detail for guild administrators to review.

---

If available, please reference related code responsible for role management and event handling in your implementation.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Emit audit message when a managed role is modified by a non-bot user #134

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull Request Overview

This PR adds monitoring and audit logging for Discord role modifications. When a managed role in a tracked guild is updated by a non-bot user, the system now sends an audit message to the guild's audit channel with details about who made the change and what was modified.

Key changes:

• Added a new handleGuildRoleUpdate event handler in the DiscordIntegrator
• Integrated the handler into the Start() method to listen for GuildRoleUpdate events
• Created a comprehensive test file documenting expected behavior (all tests currently skipped)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
server/evr_discord_integrator.go	Adds handler registration in Start() method and implements handleGuildRoleUpdate function to audit managed role changes
server/evr_discord_integrator_roleupdate_test.go	Adds skipped documentation tests describing the expected behavior of role update handling

[Copilot]

All test functions in this file are skipped with no actual test implementation. Per the custom guideline 1000000, only EVR unit tests should be included. While documentation tests can be useful, these skipped tests provide no test coverage. Consider either implementing actual unit tests using table-driven test patterns (similar to evr_enforcement_journal_test.go and evr_discord_appbot_test.go), or removing these skipped documentation tests entirely since they don't provide executable coverage.

[Copilot]

Removed in b9de6f8. The skipped documentation tests have been deleted since they provide no executable coverage. Actual unit tests for this feature would require extensive mocking infrastructure that doesn't currently exist in the codebase.

[Copilot]

[nitpick] This large switch statement to determine roleType could be refactored into a helper method on GuildGroupRoles (similar to AsSlice() and AsSet()). This would improve maintainability and keep role-related logic centralized in the GuildGroupRoles type. Consider adding a method like GetRoleType(roleID string) string to the GuildGroupRoles struct.

[Copilot]

Refactored in b9de6f8. Added GetRoleType() helper method to GuildGroupRoles, centralizing role-related logic as suggested.

[thesprockee]

@copilot

try again.

[Copilot]

@copilot

try again.

Could you clarify what you'd like me to try again? The PR currently implements:

• GuildRoleUpdate event handler with audit logging
• GetRoleType() helper method on GuildGroupRoles
• Fixed duplicate error logging
• Removed skipped test file

What specific aspect would you like me to revisit or change?