[WIP] Fix issue with chassis and heraldry settings #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement BeforeWriteStorageObjectsHook and BeforeDeleteStorageObjectsHook to enforce StorageObjects intent (or IsGlobalOperator) and block unauthorized write/delete requests by returning nil. - Clarify AfterReadStorageObjectsHook comment to specify retry when zero objects were returned. - Small TODO placement fix in BeforeListMatchesHook. - Comment out registration of the BeforeWriteStorageObjects guard in registerAPIGuards.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Bates <a@sprock.io>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
* Initial plan * Add nakama-debug to .gitignore Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
…tion (#124) * Initial plan * Extract common storage authorization logic into helper function Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
…ing (#127) * Initial plan * Add novalidation tag support for game server registration Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Add documentation for novalidation tag Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Use constant for novalidation tag to avoid magic string Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Make audit message sending async and clarify documentation Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
…ions (#128) * Initial plan * Extract common authorization logic into helper function Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Signed-off-by: Andrew Bates <a@sprock.io> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
…130) * Initial plan * Add nakama-debug to .gitignore Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Conditionally show moderator Discord ID in suspension embeds Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Add tests for conditional enforcer ID display in suspension embeds Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
* Initial plan * Initial analysis - Identify error message improvement needed Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Update error messages to include internal IP, external IP, and port Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
Use the loop variable (gID) instead of the outer groupID when calling createSuspensionDetailsEmbedField so each embed field references the correct guild instead of always using the current group.
* Initial plan * Initial plan for fixing Past Display Names embed bug Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Fix Past Display Names embed bug and add missing ServerEventsPublish method - Fixed timestamp assignment bug in createPastDisplayNameEmbed where variable 'e' was being assigned instead of 'ts' - Added comprehensive test coverage for createPastDisplayNameEmbed function - Fixed Satori build issue by implementing missing ServerEventsPublish method Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
* Added IGN Override lock toggle and interaction for user metadata * Update server/evr_discord_appbot_handlers.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Bates <a@sprock.io> * Update server/evr_discord_appbot_igp.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Bates <a@sprock.io> * Update server/evr_discord_appbot.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Bates <a@sprock.io> --------- Signed-off-by: Andrew Bates <a@sprock.io> Co-authored-by: Andrew Bates <a@sprock.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrew Bates <a@sprock.io>
…gs (#131) * Initial plan * Add daily average player loudness leaderboard stat - Add PlayerLoudnessStatisticID constant - Process VOIP_LOUDNESS remote logs to accumulate loudness data - Track total loudness, min, max, and count per player - Store metadata (min_loudness, max_loudness, count) in leaderboard records - Queue leaderboard updates with daily reset schedule - Add unit tests for loudness accumulation and average calculation - Fix satori interface compilation issue with stub method Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Add documentation for PlayerLoudness leaderboard stat Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Fix metadata type handling and documentation format - Fix metadata parsing to handle string values correctly (was trying to parse as float64) - Remove incorrect comment syntax from markdown documentation - Add test verification for metadata parsing Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Add error handling for metadata parsing and fix documentation - Add error handling for fmt.Sscanf calls with warning logs - Update documentation example to show correct string-based metadata parsing - Ensures parsing failures are logged instead of silently failing Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Refactor to use strconv instead of fmt.Sscanf for parsing - Replace fmt.Sscanf with strconv.ParseFloat/ParseInt for better performance - Update all code and documentation to use strconv functions - More appropriate and efficient for string-to-number conversion - All tests still pass with the new approach Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Improve error messages and clarify comments - Add more context to error messages for debugging - Include match ID in player not found error - Include team info in non-playing team error - Clarify that average calculation happens when reading data, not storing Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Fix error message format and improve function documentation - Fix format string in team validation error (removed missing %d placeholders) - Update ServerEventsPublish comment to follow Go documentation conventions Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> * Remove satori modifications - not needed for this feature Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: thesprockee <962164+thesprockee@users.noreply.github.com> Co-authored-by: Andrew Bates <a@sprock.io>
Signed-off-by: Andrew Bates <a@sprock.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause Identified:
In
server/evr_profile_cache.go, theLoadoutEquipItemfunction unconditionally updates BOTH chassis and heraldry/body slots when equipping tint, pattern, or decal items:Decal(chassis) andDecalBody(heraldry)Tint(chassis) andTintBody(heraldry)Pattern(chassis) andPatternBody(heraldry)The
ApplyHeraldryTintfield exists in the data model but is never used. The system needs to track which panel (chassis vs heraldry) the user is equipping from to apply changes correctly.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.