This repository was archived by the owner on Oct 13, 2021. It is now read-only.
remove membership list from main js#274
Draft
chrisguindon wants to merge 4 commits intoEclipseFdn:masterfrom
Draft
remove membership list from main js#274chrisguindon wants to merge 4 commits intoEclipseFdn:masterfrom
chrisguindon wants to merge 4 commits intoEclipseFdn:masterfrom
Conversation
Signed-off-by: Christopher Guindon <chris.guindon@eclipse-foundation.org>
|
✔️ Deploy Preview for eclipsefdn-solstice-assets ready! 🔨 Explore the source changes: e82edc3 🔍 Inspect the deploy log: https://app.netlify.com/sites/eclipsefdn-solstice-assets/deploys/61268f41903e4c0007fbb05e 😎 Browse the preview: https://deploy-preview-274--eclipsefdn-solstice-assets.netlify.app |
autumnfound
approved these changes
Aug 25, 2021
Member
Author
|
This allows us to save ~60kb for the main.js file. However, the moment that we decide to use 'isomorphic-fetch' in a "core" file, saving drops to 10kb. A core file here is simply a file that we include in our main.js which we have on all of our sites. |
Member
Author
|
Converting to draft as I am not sure the trade-off is worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org