Add new parseLink and encodePayLink methods
#680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| expires: expireDate, | ||
| isGateway: (metadata as any)?.gateway // Undocumented feature | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Payment Links Fail for Non-Public Addresses
The parsedUriToLink function only creates payment links if publicAddress is present. This misses cases where a URI only provides legacyAddress or segwitAddress, even though the internal logic can handle these address types.
peachbits
requested changes
Nov 24, 2025
src/core/currency/uri-tools.ts
Outdated
| displayName: currencyName, | ||
| networkLocation: { | ||
| contractAddress, | ||
| type: (token as any).type // Undocumented EVM token type |
Contributor
There was a problem hiding this comment.
Where did this come from?
| expires: expireDate, | ||
| isGateway: (metadata as any)?.gateway // Undocumented feature | ||
| } | ||
| } |
swansontec
force-pushed
the
william/parse-link
branch
from
8d4e20f to
1ed9bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none