Add optional memoIndex to transaction otherParams #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful if service is expecting an OP_RETURN to be a specific output index
6 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const memoOutput = sortedOutputs.splice(currentMemoIndex, 1) | ||
| sortedOutputs.splice(memoIndex, 0, memoOutput[0]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Memo Placement Error in Transactions
The memoIndex parameter in makeTx lacks bounds validation. If memoIndex is negative or exceeds the output array's length, the splice operation places the memo output at an unintended position. This could cause issues if precise memo placement is critical for transaction validity or downstream processing.
2 tasks
swansontec
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged until is successfully tested
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none