Skip to content

Fix Simplex tracking #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jon-edge wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −2
Open

Fix Simplex tracking #5910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- added: `chooseCaip19Asset` EdgeProvider API for precise wallet selection using CAIP-19 identifiers
- added: Pass OS and app version details to core context for v2/coreRollup endpoint
- changed: Append chain names to token codes in RampCreateScene
- fixed: Simplex buy/sell success status detection

## 4.42.0 (staging)

Expand Down
10 changes: 8 additions & 2 deletions src/plugins/ramps/simplex/simplexRampPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,8 +689,14 @@ export const simplexRampPlugin: RampPluginFactory = (

const orderId = link.query.orderId ?? 'unknown'
const status = link.query.status?.replace('?', '')

switch (status) {
const isTransactionApproved = link.uri.includes(
'transaction-approved'
)
const effectiveStatus = isTransactionApproved
? 'success'
: status

switch (effectiveStatus) {
case 'success': {
onLogEvent('Buy_Success', {
conversionValues: {
Expand Down
Loading