Skip to content

feat: forward landing page app image overrides#14

Merged
CodeByNikolas merged 2 commits intomainfrom
feat/add-landing-app-image-override
Mar 30, 2026
Merged

feat: forward landing page app image overrides#14
CodeByNikolas merged 2 commits intomainfrom
feat/add-landing-app-image-override

Conversation

@CodeByNikolas
Copy link
Copy Markdown

@CodeByNikolas CodeByNikolas commented Mar 30, 2026

Summary

  • forward optional image / Image values from landingPage.additionalApps into the rendered landing-page config.js
  • keep the rendered output unchanged when no override is provided
  • document the optional value in chart defaults and README

Testing

  • helm template test charts/theia-cloud --namespace test-ns --set landingPage.additionalApps.java-17-no-ls.label="Java 17 No-LS" --set landingPage.additionalApps.java-17-no-ls.image="Java-17-latest" --set landingPage.additionalApps.rust-no-ls.label="Rust No-LS"

Summary by CodeRabbit

  • New Features

    • Landing page additional apps can now optionally specify custom images to override default logos.
  • Documentation

    • Updated configuration documentation and examples to reflect support for optional custom images on additional apps.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@CodeByNikolas has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 39 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 39 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: decd99e5-f6b5-4188-ba2d-05c848a03ca2

📥 Commits

Reviewing files that changed from the base of the PR and between ae8659a and cec5ea1.

📒 Files selected for processing (1)
  • charts/theia-cloud/Chart.yaml
📝 Walkthrough

Walkthrough

This PR extends the landing page configuration to support optional per-app image overrides. The additionalApps entries now accept an optional image field alongside the existing label, which is forwarded to the rendered landing page config. Documentation and templates were updated to reflect this enhancement.

Changes

Cohort / File(s) Summary
Documentation Updates
charts/theia-cloud/README.md, charts/theia-cloud/values.yaml
Updated documentation to describe the nested additionalApps value shape, clarifying that each app entry contains a label (required) and optional image field for logo override. Example configurations were adjusted accordingly.
Template Implementation
charts/theia-cloud/templates/landing-page-config-map.yaml
Added template logic to lookup optional image or Image fields from app entries and render them into the config.js output via templating. Existing fields and structure remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

ready to merge

Poem

🐰 A carrot-colored override, so fine,
Images now dance in each app's design,
Labels and pictures, together they play,
In Helm's gentle templates, hooray! Hooray! 🎨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: forward landing page app image overrides' accurately and concisely describes the main change: adding support for optional image overrides in the landing page app configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-landing-app-image-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CodeByNikolas CodeByNikolas merged commit f3d3878 into main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant