-
Notifications
You must be signed in to change notification settings - Fork 0
fix: disable keycloak on test3 for benchmark runs #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CodeByNikolas
wants to merge
65
commits into
main
Choose a base branch
from
benchmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
eab99f7
feat: Integrate EduTheia landing page with separate tag parameter
CodeByNikolas f98c9e2
no custom
CodeByNikolas 73c40d8
check footer for new landing apge
CodeByNikolas e159b25
chore: Bump theia-cloud chart to 1.3.0-next.4 (#63)
CodeByNikolas e5c87d2
revert: Restore proper test3 footer links (remove test URLs)
CodeByNikolas 9083a5f
Apply suggestion from @Copilot
CodeByNikolas 3dde7e6
chore: Trigger rebase after main branch updates
CodeByNikolas bfe2a7d
chore: Merge main into edutheia branch - resolve Chart.lock timestamp…
CodeByNikolas 16cc1cb
rollen test
CodeByNikolas 99e350e
undo rollen
CodeByNikolas e88558e
all envs
CodeByNikolas a47e4ac
restore LS
CodeByNikolas 08d8c4c
chore: merge main into feat/edutheia-landing-page-integration and upd…
CodeByNikolas 865a6c7
fix: correct image registry paths for operator, service and landing page
CodeByNikolas 7ae3a08
fix: lowercase GHCR landing-page image references
CodeByNikolas 6a53fe8
fix: align landing-page defaults with standalone image path
CodeByNikolas d364437
fix: revert out-of-scope test3 pr-tag bumps
CodeByNikolas 21f5254
feat: configure ARC runners with GitHub backup execution mode for all…
CodeByNikolas 985715d
fix(ci): retry Helm base/CRD install on 'release already exists' race
CodeByNikolas b747324
Merge remote-tracking branch 'origin/main' into feat/landing-page-int…
CodeByNikolas 2b98737
Merge remote-tracking branch 'origin/hotfix/helm-release-race-retry' …
CodeByNikolas 79858a9
fix(ci): remove duplicate execution_mode keys in deploy-pr.yml workflow
CodeByNikolas 5096fd5
fix: disable keycloak on test3 for benchmark runs
CodeByNikolas 8d6b04e
hä??
CodeByNikolas 792f4bd
correct image tag
CodeByNikolas ca037ce
use pr images
CodeByNikolas 104825f
java-17-latest
CodeByNikolas 7bdbd38
no sidecar
CodeByNikolas 42d1011
feat(ci): add optional clean install workflow toggle
CodeByNikolas 84c0d06
Merge branch 'feature/clean-install-toggle' into benchmark
CodeByNikolas ab9102b
feat(ci): make clean install perform namespace purge before deploy
CodeByNikolas 47b5766
Merge branch 'feature/clean-install-toggle' into benchmark
CodeByNikolas 1a913fb
fix(ci): delete session/workspace CRDs with grouped resource names
CodeByNikolas 75e76db
Merge branch 'feature/clean-install-toggle' into benchmark
CodeByNikolas 3c24f99
chore(ci): remove fixed post-cleanup wait from clean install
CodeByNikolas 636c3d7
Merge branch 'feature/clean-install-toggle' into benchmark
CodeByNikolas e3d645c
back to latest
CodeByNikolas 728b359
hä junge??
CodeByNikolas 7a7a92a
check new deployment
CodeByNikolas c2fc148
new pr
CodeByNikolas 3fb95ce
less preload
CodeByNikolas 6ef8ba6
maxINstances
CodeByNikolas d108d4d
130
CodeByNikolas d3ebc08
false
CodeByNikolas 4d5838d
fix(test3): use eduidec landing page image repository
CodeByNikolas 42e84aa
merge: adopt landing image path update from chore branch
CodeByNikolas f169694
fix(test3): align landing image paths with eduidec repository
CodeByNikolas e532605
bitte richtig jetzt
CodeByNikolas 1e55177
omgomg
CodeByNikolas 8b07630
bruuuuuder
CodeByNikolas 55ac3c1
new pr
CodeByNikolas 29bef9a
test test
CodeByNikolas 0492130
test ceph
CodeByNikolas 41bd05e
Merge origin/main into benchmark
CodeByNikolas 87ce2af
omg
CodeByNikolas 4fb5251
more eager
CodeByNikolas 3f89c9d
normaliue
CodeByNikolas 22baabd
image labels
CodeByNikolas 195a68f
Merge origin/main into benchmark
CodeByNikolas 9849e33
Align prod image tags with main after merge
CodeByNikolas 21cee22
no eager start
CodeByNikolas 5e8368e
hoch limit + ephemeral
CodeByNikolas 77ea9cf
f aus
CodeByNikolas 0197378
true
CodeByNikolas 50976b3
false
CodeByNikolas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,8 +43,8 @@ theia-cloud: | |
| interval: 3 | ||
|
|
||
| operator: | ||
| image: ghcr.io/eduide/eduide-cloud/operator:pr-70 | ||
| #eagerStart: false | ||
| image: ghcr.io/eduide/eduide-cloud/operator:latest | ||
| eagerStart: false | ||
| replicas: 1 | ||
| sessionsPerUser: 10 | ||
| # Test3 runs on the parma cluster where Longhorn is the default storage backend. | ||
|
|
@@ -56,7 +56,7 @@ theia-cloud: | |
| ephemeral-storage: "256Mi" | ||
|
|
||
| service: | ||
| image: ghcr.io/eduide/eduide-cloud/service:pr-70 | ||
| image: ghcr.io/eduide/eduide-cloud/service:latest | ||
| adminApiTokenSecret: | ||
| name: service-admin-api-token | ||
| key: ADMIN_API_TOKEN | ||
|
|
@@ -65,19 +65,12 @@ theia-cloud: | |
| # Index 11 is oauth2-proxy (distroless); the workflow does not override it. | ||
| preloading: | ||
| images: | ||
| - ghcr.io/eduide/eduidec-landing-page:latest | ||
| - ghcr.io/eduide/eduide/java-17:latest | ||
| - ghcr.io/eduide/eduide/c:latest | ||
| - ghcr.io/eduide/eduide/javascript:latest | ||
| - ghcr.io/eduide/eduide/ocaml:latest | ||
| - ghcr.io/eduide/eduide/rust:latest | ||
| - ghcr.io/eduide/eduide/python:latest | ||
| - ghcr.io/eduide/eduide/java-17-no-ls:pr-70 | ||
| - ghcr.io/eduide/eduide/rust-no-ls:pr-70 | ||
| - ghcr.io/eduide/eduide/langserver-java:pr-70 | ||
| - ghcr.io/eduide/eduide/langserver-rust:pr-70 | ||
| - image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0 | ||
| args: ["--version"] | ||
| - ghcr.io/eduide/eduide/java-17-no-ls:latest | ||
| - ghcr.io/eduide/eduide/rust-no-ls:latest | ||
| - ghcr.io/eduide/eduide/langserver-java:latest | ||
| - ghcr.io/eduide/eduide/langserver-rust:latest | ||
|
|
||
| imagePullPolicy: Always | ||
|
|
||
|
|
@@ -98,7 +91,7 @@ theia-cloud: | |
| # you might need this. If you used my simplified template, this is ignored. | ||
| logoFileExtension: "png" | ||
| appDefinition: "java-17-no-ls" | ||
| ephemeralStorage: true | ||
| ephemeralStorage: false | ||
| additionalApps: | ||
| java-17-no-ls: | ||
| label: Java 17 No-LS | ||
|
|
@@ -107,8 +100,8 @@ theia-cloud: | |
| label: Rust No-LS | ||
| image: "rust" | ||
| infoTitle: "🚀 Welcome to Test3 IDE Environment" | ||
| infoText: "Test environment for Theia with external language server architecture (PR #70). The IDE runs separately from the language server for improved performance and modularity." | ||
| loadingText: "⚡ Setting up your development workspace..." | ||
| infoText: "Welcome to Theia Test 3" | ||
| loadingText: "Preparing your personal Online IDE..." | ||
| footerLinks: | ||
| attribution: | ||
| text: "Built by TUM LS1 Team 👨💻" | ||
|
|
@@ -125,7 +118,7 @@ theia-cloud: | |
| url: "https://aet.cit.tum.de/" | ||
|
|
||
| keycloak: | ||
| enable: true | ||
| enable: false | ||
|
Comment on lines
118
to
+121
|
||
|
|
||
| # -- Key cloak auth URL. Only has to be specified when enable: true | ||
| authUrl: "https://keycloak.ase.in.tum.de/" | ||
|
|
@@ -137,20 +130,26 @@ theia-cloud: | |
| clientId: "theia-test" | ||
|
|
||
| theia-appdefinitions: | ||
| defaultImageTag: pr-70 | ||
| defaultImageTag: latest | ||
| apps: | ||
| - name: java-17-no-ls | ||
| image: ghcr.io/eduide/eduide/java-17-no-ls | ||
| minInstances: 1 | ||
| minInstances: 5 | ||
| maxInstances: 200 | ||
| sidecars: | ||
|
Comment on lines
135
to
139
|
||
| - name: langserver | ||
| image: ghcr.io/eduide/eduide/langserver-java | ||
| port: 5000 | ||
| languages: [java] | ||
| mountWorkspace: true | ||
| - name: java-17-latest | ||
| image: ghcr.io/eduide/eduide/java-17 | ||
| minInstances: 5 | ||
| maxInstances: 200 | ||
| - name: rust-no-ls | ||
| image: ghcr.io/eduide/eduide/rust-no-ls | ||
| minInstances: 1 | ||
| minInstances: 5 | ||
| maxInstances: 200 | ||
| sidecars: | ||
| - name: langserver | ||
| image: ghcr.io/eduide/eduide/langserver-rust | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,10 @@ theia-cloud: | |
|
|
||
| operator: | ||
| image: ghcr.io/eduide/eduide-cloud/operator:latest-e431a13 | ||
| #eagerStart: false | ||
| # Production keeps Ceph RBD and does not configure sidecars. | ||
| # Disable eager-start so the operator stays on the workspace-backed RWO path | ||
| # instead of creating prewarmed RWX PVCs that do not fit csi-rbd-sc. | ||
| eagerStart: false | ||
| replicas: 3 | ||
|
Comment on lines
44
to
50
|
||
| sessionsPerUser: 10 | ||
| storageClassName: csi-rbd-sc | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says Test3 uses Longhorn as the default storage backend, but
storageClassNameis set tocsi-rbd-sc. Either update the comment to match the new backend, or revertstorageClassNametolonghornif that’s still the correct class for the parma cluster.