Merged
Conversation
koisland
reviewed
May 17, 2025
koisland
reviewed
May 17, 2025
koisland
reviewed
May 17, 2025
Collaborator
|
Hi @jwertz01. Thanks for the PR. Once the comments have been resolved and the tests pass, I'll approve these changes. Also, if you haven't already, you need to fix the Eichler lab GitHub's budget for LFS for CI to work. I would set it to $10 as that's the limit for free users. See https://github.com/orgs/community/discussions/151710 Thanks, |
Contributor
Author
|
@koisland Made the requested changes and I'll look into the budget for CI- thanks for checking! |
Collaborator
|
Everything looks good to me! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented some changes requested by lab members (see also logsdon-lab/CenPlot#13 ):