Stability upgrades#127
Merged
jaykalinani merged 28 commits intoEinsteinToolkit:developmentfrom Feb 19, 2026
Merged
Conversation
Collaborator
MChabanov
commented
Feb 17, 2026
MChabanov
commented
- conservatives are in a group: possible to use prolongate_per_group parameter
- ceilings on sigma and inv_beta
- added helper grid functions
- caps on velocity after reconstruction (with parameter v_vec)
- minor change on lower limit of tau
- remove unused code (related to cons_error_limit)
- make prolongation operator and order explicit (hard-coded) in interface.ccl
- make reconstruction methods steerable
lwJi
approved these changes
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
jaykalinani
reviewed
Feb 17, 2026
Collaborator
jaykalinani
left a comment
jaykalinani
left a comment
There was a problem hiding this comment.
All looks good in general! Thanks for the effort!!
P.S. if not, I would suggest clang-formatting the edited files
jaykalinani
reviewed
Feb 18, 2026
acwen11
reviewed
Feb 18, 2026
Collaborator
acwen11
left a comment
acwen11
left a comment
There was a problem hiding this comment.
Other than the one comment this looks good!
This reverts commit acf1a66.
jaykalinani
reviewed
Feb 19, 2026
jaykalinani
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.