Skip to content

AsterX: set prolongation tags for olds and ks#128

Merged
lwJi merged 3 commits intoEinsteinToolkit:developmentSCfrom
acwen11:SC_prolong_tags
Mar 27, 2026
Merged

AsterX: set prolongation tags for olds and ks#128
lwJi merged 3 commits intoEinsteinToolkit:developmentSCfrom
acwen11:SC_prolong_tags

Conversation

@acwen11
Copy link
Copy Markdown
Collaborator

@acwen11 acwen11 commented Mar 26, 2026

No description provided.

@acwen11 acwen11 requested a review from lwJi March 26, 2026 15:37
Copy link
Copy Markdown
Collaborator

@lwJi lwJi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Could you update the unit test of magTOV_Z4c_AMR_SC

@lwJi
Copy link
Copy Markdown
Collaborator

lwJi commented Mar 26, 2026

unit test of magTOV_Z4c_AMR_SC is still falling. Please double check if you used the same branch when you regenerate the new test files.

@acwen11
Copy link
Copy Markdown
Collaborator Author

acwen11 commented Mar 26, 2026

unit test of magTOV_Z4c_AMR_SC is still falling. Please double check if you used the same branch when you regenerate the new test files.

Currently looking into this. To the best of my knowledge, I am using the same branches of CarpetX, AsterX, and SpacetimeX as specified in asterx.th. The test files were generated by compiling with gcc on Vista, which would be different from what is done in the CI tests, but I'm not sure where the difference would be coming from.

@lwJi
Copy link
Copy Markdown
Collaborator

lwJi commented Mar 26, 2026

unit test of magTOV_Z4c_AMR_SC is still falling. Please double check if you used the same branch when you regenerate the new test files.

Currently looking into this. To the best of my knowledge, I am using the same branches of CarpetX, AsterX, and SpacetimeX as specified in asterx.th. The test files were generated by compiling with gcc on Vista, which would be different from what is done in the CI tests, but I'm not sure where the difference would be coming from.

In this case, are you able to undo the change to the test files. I will take care of the rest

@lwJi lwJi merged commit 67388ae into EinsteinToolkit:developmentSC Mar 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants