Skip to content

CarpetX: make driver.hxx, schedule.hxx and timer.hxx visible to other thorns #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lwJi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CarpetX: make driver.hxx, schedule.hxx and timer.hxx visible to other thorns #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f1b390
CarpetX: make driver.hxx and schedule.hxx visible to other thorns
lwJi Oct 31, 2024
91b87fa
CarpetX: make timer.hxx visible to other thorns
lwJi Nov 12, 2024
14ea39b
ODESolvers: use proper interface to access CarpetX headers
lwJi Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CarpetX/interface.ccl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ USES INCLUDE HEADER: loop.hxx
USES INCLUDE HEADER: loop_device.hxx

INCLUDES HEADER: driver.hxx IN driver.hxx
INCLUDES HEADER: schedule.hxx IN schedule.hxx
INCLUDES HEADER: reduction.hxx IN reduction.hxx
INCLUDES HEADER: timer.hxx IN timer.hxx



Expand Down
3 changes: 3 additions & 0 deletions ODESolvers/interface.ccl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
IMPLEMENTS: ODESolvers

USES INCLUDE HEADER: div.hxx
USES INCLUDE HEADER: driver.hxx
USES INCLUDE HEADER: schedule.hxx
USES INCLUDE HEADER: timer.hxx



Expand Down
8 changes: 3 additions & 5 deletions ODESolvers/src/solve.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
// TODO: Don't include files from other thorns; create a proper interface
#include "../../CarpetX/src/driver.hxx"
#include "../../CarpetX/src/schedule.hxx"
#include "../../CarpetX/src/timer.hxx"

#include <cctk.h>
#include <cctk_Parameters.h>
#include <cctk_Arguments.h>
#include <util_Table.h>

#include <div.hxx>
#include <driver.hxx>
#include <schedule.hxx>
#include <timer.hxx>

#include <AMReX_MultiFab.H>

Expand Down