CarpetX: Added option to exclude boundaries in 1D tsv output#373
Open
lucass-carneiro wants to merge 2 commits intomainfrom
Open
CarpetX: Added option to exclude boundaries in 1D tsv output#373lucass-carneiro wants to merge 2 commits intomainfrom
lucass-carneiro wants to merge 2 commits intomainfrom
Conversation
rhaas80
approved these changes
Feb 26, 2026
Collaborator
|
Does this output just the outer boundary points, or does it output ghost points as well? If so, the documentation should be changed. |
Contributor
Author
As far as my understanding goes, TSV files don't output ghosts, only outer boundaries (points starting with negative indices and extending beyond the cell size). This parameter excludes the outer boundaries in TSV output data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to exclude boundaries when saving 1D TSV files