Incresed maxncomps to accomdate more grid functions#378
Open
annamalai-ps wants to merge 1 commit intomainfrom
Open
Incresed maxncomps to accomdate more grid functions#378annamalai-ps wants to merge 1 commit intomainfrom
annamalai-ps wants to merge 1 commit intomainfrom
Conversation
annamalai-ps
requested review from
eschnett and
rhaas80
and removed request for
eschnett
rhaas80
requested changes
Mar 23, 2026
Member
rhaas80
left a comment
rhaas80
left a comment
There was a problem hiding this comment.
typo in commit message, commit message should start with "CarpetX: "
80 is plenty. I assume the 640 bytes this allocates are not a problem on GPUs?
Collaborator
|
80 is a lot. How many do you actually need? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.