-
Notifications
You must be signed in to change notification settings - Fork 11
Multipatch support in NewRadX #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucass-carneiro
wants to merge
10
commits into
main
Choose a base branch
from
features/NewRadX-multipatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a1931d7
NewRadX: Added the ability to use CapyrX Multipatch
lucass-carneiro cc0df57
NewRadX: Use multipatch projections
lucass-carneiro dc2a421
NewRadX: Relaxed requirements of specific patch system setup
lucass-carneiro 353ca7d
NewRadX: Added radpower correction for multipatch
lucass-carneiro 8097aed
Add CapyrX thorns to spacetimex.th
lucass-carneiro c5c8c0d
Update repository paths for CapyrX thorns
lucass-carneiro cac008a
NewRadX: Removed explicit references to CapyrX
lucass-carneiro 9351501
Merge remote-tracking branch 'origin' into features/NewRadX-multipatch
lucass-carneiro 0bed759
Updated CI thornlist
lucass-carneiro d8e353a
NewRadX: addressed requested changes
lucass-carneiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| # Parameter definitions for thorn NewRadX | ||
|
|
||
| CCTK_BOOLEAN apply_inner_boundary "Apply radiative BC at inner boundary of a multipatch systems, if such boundary exists (e.g. Thornburg06 inner sphere)" STEERABLE=always | ||
| { | ||
| } "no" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a use case where one would want to steer the parameter
apply_inner_boundary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I can't foresee such use case at the moment, but it may be required by someone in the future.