Fixing problem with depdendencies of the crate #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were analyzing our depdendencies and found out that some of the crates seems to be referenced for no clear reason.
This PR does two things:
instato the dev-deps, so the downstream crates won't have it as a dependency - it is only used in a single place in testsCargo.lockand update gitignore accordingly to the Rust Team Code Guidelines: https://doc.rust-lang.org/nightly/cargo/faq.html#why-have-cargolock-in-version-controlIt the current redaction of the guidlines it is more vague than it was before, but overall the rule of a thumb that only binary applications should be commiting the
.lockfile. I noticed that because movinginstato the dev dependencies left.lockfile in the invalid state (they were no longer used but were listed there anyway as you can see in the commit history).