Skip to content

Quests - 21030649#52

Merged
Jebzou merged 29 commits intoElectronicObserverEN:masterfrom
inazuma074:master
Jan 4, 2026
Merged

Quests - 21030649#52
Jebzou merged 29 commits intoElectronicObserverEN:masterfrom
inazuma074:master

Conversation

@inazuma074
Copy link
Contributor

No description provided.

@inazuma074
Copy link
Contributor Author

Sorry for the duplicated commits in this PR. I'm still learning the process, so I sent everything at once by mistake. I will submit future updates in separate branches to keep the PRs clean. Thanks for understanding!

@Jebzou
Copy link
Member

Jebzou commented Jan 4, 2026

It's OK to have multiple commit in the same PR, no problem at all !
As long as you create the PR only when it's ready to be merged.
If you want to create a PR and keep adding commits to it, you can use the draft feature of github

@myangelkamikaze
Copy link
Member

myangelkamikaze commented Jan 4, 2026

The reason why the duplicate commits show up is because we use squash merge. The easiest way to avoid it would be to delete your fork and make a new fork after a merge. But because we squash merge, the duplicate commits don't really matter, so you don't need to worry about it.

"desc_jp": "「白露改」旗艦の第二七戦隊を含む艦隊をオリョール海に展開、同海域の敵艦隊を撃滅せよ!",
"desc": "Sortie Shiratsuyu Kai as flagship, Shigure, Harusame and Samidare and up to 2 additional ships and score an S rank victory against World 2-3 Boss."
"desc": 「시라츠유 개」 기함의 제27전대를 포함하는 함대를 오룔 해에 전개, 해당 해역의 적 함대를 격멸하라!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start double quote is missing

@inazuma074
Copy link
Contributor Author

Fixed the missing start double quote.

@Jebzou Jebzou merged commit 79e3383 into ElectronicObserverEN:master Jan 4, 2026
1 check passed
@Jebzou
Copy link
Member

Jebzou commented Jan 4, 2026

Thank you for the pull request !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants