Merged
Conversation
Jebzou
reviewed
Aug 19, 2024
Jebzou
reviewed
Aug 19, 2024
Jebzou
reviewed
Aug 19, 2024
Jebzou
reviewed
Aug 19, 2024
Jebzou
approved these changes
Aug 19, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older data might not work totally as expected, because it's using the current ship/equipment data trying to simulate what happened during the sortie, meaning if you don't have the exact ship/equipment anymore, it can break stuff.
The missing data can be reconstructed, but it's a lot of work and technically isn't needed for the current use case, which is mainly for #484 testing.
Data from before the opening torpedo rework won't work either till #484 is merged. That should come after this PR is merged.