Add azimuth display and enable min/max for inputs#106
Add azimuth display and enable min/max for inputs#106parksjr merged 3 commits intoElement84:mainfrom
Conversation
parksjr
left a comment
There was a problem hiding this comment.
Sweet new shapes! I have a very minor inline comment on a couple long lines, do with that what you want. Main thing is the global test coverage threshold is hitting. If you look at the MapPreview.test.js file, there are existing tests for the marker and the polygon, I think if you add similar tests there for the new shapes (Circle, Polyline, Semicircle) then that should probably appease the threshold error. Let me know if there are any issues with that
Co-authored-by: Michael Parks <mike@parksjr.tech>
Good call on the readability update, pushed that in. Added some tests as well, let me know if those look good to you. Thanks for taking a look! |
Adds an azimuth display which takes a start and end azimuth angle and displays the result as a semicircle. If it's a 0-360 range nothing will display. If the start and end are the same it will be a line. Also enables passing min/max values to an input.