Skip to content

Add azimuth display and enable min/max for inputs#106

Merged
parksjr merged 3 commits intoElement84:mainfrom
log0s:azimuth-display
Mar 5, 2025
Merged

Add azimuth display and enable min/max for inputs#106
parksjr merged 3 commits intoElement84:mainfrom
log0s:azimuth-display

Conversation

@log0s
Copy link
Contributor

@log0s log0s commented Feb 27, 2025

Adds an azimuth display which takes a start and end azimuth angle and displays the result as a semicircle. If it's a 0-360 range nothing will display. If the start and end are the same it will be a line. Also enables passing min/max values to an input.

Copy link
Collaborator

@parksjr parksjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet new shapes! I have a very minor inline comment on a couple long lines, do with that what you want. Main thing is the global test coverage threshold is hitting. If you look at the MapPreview.test.js file, there are existing tests for the marker and the polygon, I think if you add similar tests there for the new shapes (Circle, Polyline, Semicircle) then that should probably appease the threshold error. Let me know if there are any issues with that

@log0s
Copy link
Contributor Author

log0s commented Mar 3, 2025

Sweet new shapes! I have a very minor inline comment on a couple long lines, do with that what you want. Main thing is the global test coverage threshold is hitting. If you look at the MapPreview.test.js file, there are existing tests for the marker and the polygon, I think if you add similar tests there for the new shapes (Circle, Polyline, Semicircle) then that should probably appease the threshold error. Let me know if there are any issues with that

Good call on the readability update, pushed that in. Added some tests as well, let me know if those look good to you. Thanks for taking a look!

@parksjr parksjr merged commit c0d50c7 into Element84:main Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants