Xpay: use headercount as block height refering point #8641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xpay gets the block height from the
block_addednotification.In certain situations, the backend may be out of sync and in that case payment attempts will fail with
incorrect_or_unknown_payment_detailsif we are too far in the past.A possible solution is to use the
headercountas the correct block height.There is no notification that we can use to fetch
headercount, so we add as an alternative an additionalRPC call to
getchaininfoat the start of the payment to update our internal block height.Addresses issue #8612.
It uses a similar approach to #7190.