Skip to content

Conversation

@rustyrussell
Copy link
Contributor

This doesn't happen much in real life, but it's certainly possible, so do what pay does here.

Fixes: #8612

…ockheight.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…kheight.

This doesn't happen much in real life, but it's certainly possible, so do what pay does here.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#8612
Changelog-Added: `xpay` will now wait if it suspects a payment failure is due to a height disagreement with the final node.
@rustyrussell rustyrussell added this to the v25.12 milestone Oct 29, 2025
Copy link
Collaborator

@Lagrang3 Lagrang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
It is nice that you are able to fetch the blockheight on the erring node from the incorrect_or_unknown_payment_details message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xpay: Unhelpful error message when payment fails due to height disagreement and doesn't retry

2 participants