Remove libsodium and lowdown submodules to fix recursive clone #8652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These submodules were causing failures during recursive git clone operations. The submodule entries were still registered in the git tree even though they were removed from .gitmodules, causing: "fatal: No url found for submodule path 'external/lightning/external/libsodium'" and similar errors for lowdown. This removes both submodule references from the git index to resolve recursive submodule initialization failures (exit code 128). Changelog-None
|
Thanks, great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These submodules were causing failures during recursive git clone operations. The submodule entries were still registered in the git tree even though they were removed from .gitmodules, causing: "fatal: No url found for submodule path 'external/lightning/external/libsodium'" and similar errors for lowdown.
This removes both submodule references from the git index to resolve recursive submodule initialization failures (exit code 128).
Changelog-None
This breaks BitcoinFuzz CI when updating to the latest Core Lightning commit. The recursive submodule initialization fails with:
git submodule update --init --recursive external/lightningSee: https://github.com/bitcoinfuzz/bitcoinfuzz/actions/runs/18974054866/job/54188726928?pr=314