Skip to content

Fix FIX-ME request#2

Open
TheTechRobo wants to merge 12 commits intoElive:elivefrom
TheTechRobo:elive
Open

Fix FIX-ME request#2
TheTechRobo wants to merge 12 commits intoElive:elivefrom
TheTechRobo:elive

Conversation

@TheTechRobo
Copy link
Copy Markdown

@TheTechRobo TheTechRobo commented Nov 11, 2020

Also...

  • Better README.md
  • Remove some outdated comments
  • Fix a few links

Notes:

  • I used this source to help out: https://stackoverflow.com/a/4804039/9654083
  • I used this source for making a "dummy" /etc/elive-version because I'm not at Elive right now: http://forum.elivecd.org/read.php?5,5255 (I googled /etc/elive-version to find this)
  • Please enable the Issues section in the settings, so we can report bugs (it's disabled by default on forks)
  • You say that you temporarily hardcoded it - I couldn't find this, so please, either explain to me or merge this PR and fix it yourself
  • Finally, I'd suggest "squash and merge" (it's in the dropdown beside Merge pull request) because otherwise it may clutter up the commit history.

@Thanatermesis
Copy link
Copy Markdown
Member

I see changes in the source code, it is verified that it correctly works with these changes especially into the related things that depends of this code ?

ittussarom retals mail ynohtna added 2 commits November 11, 2020 17:30
@TheTechRobo
Copy link
Copy Markdown
Author

@Thanatermesis for some reason it was working earlier and not now, thanks for catching that. currently workingon fixing the issue

depends on this code

What depends on this code, so that I can test it?

@TheTechRobo
Copy link
Copy Markdown
Author

TheTechRobo commented Nov 11, 2020

I found the issue in my fork by debugging. It's because there's a space between '383' and 'KB/s' and in my dummy file I didn't have that field. I'm not sure how to get around this - I'll keep thinking.

In case you're wondering, here's my debug output:

~/e/t/u/l/elive-welcome git:elive ❯❯❯ python3 elive-welcome.py
key: elive-codename; val: beta
key: elive-version; val: 3.8.8
key: debian-version; val: buster
key: date-builded; val: 2020-02-29
key: stable-release; val: no
key: fingerprint; val: a4cbe0c5aec17a4b17d62665e95573991c43f17c
key: first-user; val: thetechrobo
key: kernel; val: 4.19.0-8-amd64
key: machine-id; val: systemuuidce9dcc70-baf7-11de-bba9-001e33fd7a42
Traceback (most recent call last):
  File "elive-welcome.py", line 306, in <module>
    EliveWelcome()
  File "elive-welcome.py", line 32, in __init__
    key, val = fixedLine.split()
ValueError: too many values to unpack (expected 2)
~/e/t/u/l/elive-welcome git:elive ❯❯❯

@TheTechRobo
Copy link
Copy Markdown
Author

TheTechRobo commented Nov 11, 2020

Thinking - maybe I could use regex to look for internet-average-speed: BLAH BLAH/s and remove the space. Sounds complicated tho - I'll keep thinking. Unless of course you wanted to help with that.

@TheTechRobo TheTechRobo marked this pull request as draft November 12, 2020 13:33
TheTechRobo and others added 5 commits November 12, 2020 08:36
Elive Forum
Replace wikipedia link with elive forum topic about it
Also...
Comment out useless stuff
@TheTechRobo TheTechRobo marked this pull request as ready for review November 13, 2020 13:39
@TheTechRobo
Copy link
Copy Markdown
Author

I fixed it using a "hacky" approach - it looks for a ValueError while doing it; if so it will combine the third value and the second value.

@TheTechRobo
Copy link
Copy Markdown
Author

Can you test this? It works for me, but I'd rather have two pairs of eyes rather than just one. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants