Wrong usage of stores #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Alright, should be good & ready now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that this is currently a draft, the code is not refined or safe yet ;))
Here's a comment from your code:
But that is not necessarily true, a Store contains the components per reference based on the world, not the player.
This means that if you decide to switch worlds then updating (or hiding) becomes impossible since you save the store.
This pull request essentially changes that so that stores are not being saved but retrieved just like Player components.
I'm still testing quite a bit and this is specifically for HUDs, since you wouldn't change worlds anyway when you're in a page. (pretty sure they close, not 100%)