This repository was archived by the owner on May 19, 2021. It is now read-only.
Development #1
Open
Development #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors, redirections and Ui changes need to be done
spidergears
suggested changes
Aug 1, 2019
spidergears
suggested changes
Aug 2, 2019
app/assets/javascripts/custom.js
Outdated
| } | ||
|
|
||
| var taskNamePartial = []; | ||
| var taskChecked = []; |
app/assets/javascripts/custom.js
Outdated
| $(".tasklistUpdateButton").on("click", renderUpdateTasklist); | ||
| }); | ||
|
|
||
| function inputForTask(tasklistId) { |
app/assets/javascripts/custom.js
Outdated
| if (taskChecked[taskId] == true) { | ||
| $("#checkbox" + taskId).attr("checked", "checked"); | ||
| } | ||
| $(".taskname").on("click", renderUpdate); |
app/assets/javascripts/custom.js
Outdated
| $("#newtasks").show(); | ||
| $("#newtasks").addClass("card"); | ||
| $("#newtasks").append(input); | ||
| $(".createNewTaskButton").on("click", createTask); |
app/assets/javascripts/custom.js
Outdated
| $("#newtasklist") | ||
| .html(inputForTasklist()) | ||
| .append("<br>"); | ||
| $("#createTasklistButton").on("click", createTasklist); |
app/controllers/tasks_controller.rb
Outdated
| else | ||
| render 'edit' | ||
| end | ||
| @task = @tasklist.tasks.find(params[:id]) |
| @@ -0,0 +1,8 @@ | |||
| .row.algin-middle.tasklistname{id: "tasklist_list#{@tasklist.id}"} | |||
| .col-sm-8 | |||
| .tasklist_list{"data-index": current_user.tasklists.count - 1, "data-tasklistid": @tasklist.id, id: "tasklist#{@tasklist.id}"} | |||
app/views/tasklists/_tasks.html.haml
Outdated
| @@ -0,0 +1,22 @@ | |||
| .tab-content | |||
| -@tasks.each do |task| | |||
| .row | |||
app/views/tasklists/_tasks.html.haml
Outdated
| %br | ||
| .row | ||
| %br | ||
| %button.btn.btn-primary#addTaskButton{"data-tasklistid": params[:id]} Add Task |
There was a problem hiding this comment.
params should be referenced in view
config/routes.rb
Outdated
| resources :tasklists do | ||
| resources :tasks | ||
| member do | ||
| get 'render_tasks' |
There was a problem hiding this comment.
tasks
consider using nested resource routes
Active tasklist set setActivetasklist fuction removed
spidergears
reviewed
Aug 6, 2019
app/assets/javascripts/custom.js
Outdated
| @@ -0,0 +1,370 @@ | |||
| $(document).ready(function() { | |||
| const storage = localStorage.getItem("selectedTasklistCount"); | |||
There was a problem hiding this comment.
why such a stupid name? storage
What does the store contain?
app/views/tasks/_task.html.haml
Outdated
| %span.fa.fa-edit#taskUpdate.updateTask{"data-tasklistid": @task.tasklist.id, "data-taskid": @task.id} | ||
| .col-sm-1.align-self-center | ||
| %span.far.fa-trash-alt.taskDelete#taskDelete{"data-tasklistid": @task.tasklist.id, "data-taskid": @task.id} | ||
| %br No newline at end of file |
config/routes.rb
Outdated
| resources :tasklists do | ||
| resources :tasks | ||
| member do | ||
| get 'render_tasks' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.