Skip to content

Fix copilot instructions#22

Merged
hiyouga merged 1 commit intomainfrom
hiyouga/in
Jan 1, 2026
Merged

Fix copilot instructions#22
hiyouga merged 1 commit intomainfrom
hiyouga/in

Conversation

@hiyouga
Copy link
Copy Markdown
Contributor

@hiyouga hiyouga commented Jan 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 1, 2026 15:05
@hiyouga hiyouga merged commit 013858c into main Jan 1, 2026
6 checks passed
@hiyouga hiyouga deleted the hiyouga/in branch January 1, 2026 15:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the copilot instructions documentation by clarifying that make test runs unit tests specifically, and adds a new "Testing" section with common development commands.

Key Changes:

  • Clarified that make test runs unit tests rather than "all tests"
  • Added a new "Testing" section consolidating common development commands

Comment on lines +82 to +85
- Run linting: `make style`
- Format code: `make format`
- Run Python scripts: `uv run python <script>.py`
- Run unit tests: `make test`
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new "Testing" section duplicates information already present in the "Using Make Commands" section (lines 64-68). The commands for linting, formatting, and running tests are already documented above. Consider removing this redundant section or consolidating it with the existing "Using Make Commands" section to maintain a single source of truth for these commands.

Suggested change
- Run linting: `make style`
- Format code: `make format`
- Run Python scripts: `uv run python <script>.py`
- Run unit tests: `make test`
- Run Python scripts via `uv`: `uv run python <script>.py`

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants