Fetch products on Cart page reload#3
Open
tomzi8571 wants to merge 1 commit intoEmbarkXOfficial:mainfrom
Open
Conversation
When reloading the cart page the products disappear in the redux state. So changing the quantity doesn't work anymore, since it can't match products in the redux state anymore. It gives the error getState().products is null. Also, if you used a filter on the product page, then only the filtered products would be in the redux state. If you added already products before you filtered, you also can't change the quantitiy of those. Fetching the products fixes that issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reloading the cart page the products disappear in the redux state. So changing the quantity doesn't work anymore, since it can't match products in the redux state anymore. It gives the error getState().products is null.
Also, if you used a filter on the product page, then only the filtered products would be in the redux state. If you added already products before you filtered, you also can't change the quantitiy of those.
Fetching the products fixes that issue