fix: notify client of timeout and cleanup #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
When transport times out or has a reception failure, it should inform readers that it's message buffer is invalid. Set the status of the codec to the error, so a correct error handler is triggered in the client.
elupus
force-pushed
the
arbitrator-timeout
branch
from
e9b4e6f to
cc68692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
When transport times out, and the client is woken up. It should be informed
that it's message buffer is invalid, as well as given the reason for it's wakeup.
Set the status of the codec to the correct error, so
a correct error handler is triggered in the client.
To Reproduce
Trigger a timeout in underlying protocol, when a client is waiting for a response.
Expected behavior
Client is signaled that a timeout occured.
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context