Skip to content

Conversation

@daphne-cornelisse
Copy link
Collaborator

@daphne-cornelisse daphne-cornelisse commented Oct 3, 2023

Description

This pull requests adds Sphinx documentation and hosted docs using Github Pages to the EMERGE Nocturne package.

Changes Made

The following changes were made in the feature/add_sphinx_docs branch:

  • Sphinx docs:
    • Added Sphinx documentation with initial documentation skeleton
  • Github workflow & Github Pages:
    • Added simple Github workflow for hosting Sphinx docs using Github Pages

Related Issues

This pull request resolves the no outstanding issues.

Review checklist

  • Review file changes
  • Build and review docs locally, steps:
    • Install documentation requirements, either poetry install --only=docs or pip install -r ./requirements.docs.txt
    • Build Sphinx docs by running cd docs; make html; cd ..
    • Open and review docs locally by opening ./docs/build/index.html in your browser of choice
  • Test Github workflow and review Github Pages docs

@daphne-cornelisse daphne-cornelisse self-assigned this Oct 3, 2023
@daphne-cornelisse daphne-cornelisse force-pushed the feature/add_sphinx_docs branch 5 times, most recently from 106f6a7 to 07a8411 Compare October 3, 2023 13:21
…rge-Lab/nocturne into feature/add_sphinx_docs
@daphne-cornelisse daphne-cornelisse marked this pull request as ready for review October 3, 2023 13:39
@eugenevinitsky
Copy link

Should I review this?

@daphne-cornelisse
Copy link
Collaborator Author

daphne-cornelisse commented Oct 9, 2023 via email

@eugenevinitsky
Copy link

Oh I idn't get a notification, I was just futzing around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants