Clean the path the same way on all platforms#81
Open
triple-j wants to merge 1 commit intoEmersont1:mainfrom
Open
Clean the path the same way on all platforms#81triple-j wants to merge 1 commit intoEmersont1:mainfrom
triple-j wants to merge 1 commit intoEmersont1:mainfrom
Conversation
Owner
|
This is something I'm not sure about. The path cleanup is overzealous for linux and I (personally) am not a fan of the human readable names - I think escaping a |
Contributor
Author
|
I think compatibility across platforms is more important than to allow a few extra characters in Linux filenames. As I mentioned before, those extra characters can cause problems when dealing with multiple platforms. Here are some use cases that would be problematic if those extra characters aren't replaced:
Those are issue I've dealt with in the past and is why I always strip out characters that would be problematic for Windows, even if I mainly use Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing
--human-folderson Linux and ran into an issue where game names that contain a forward slash (/) would be broken up into multiple folders. So I removed the platform check inclean_path().This is also better for compatibility. It's rare, but this allows someone to move their folders to different platforms. Since the files/folders are now created the same on all platform, the user won't accidentally re-download files if they run this project on multiple platforms.