Allow the download directory to be different from the current working directory#83
Allow the download directory to be different from the current working directory#83triple-j wants to merge 3 commits intoEmersont1:mainfrom
Conversation
To remove the need for the `Game` class to parse `sys.argv`, we'll store the option in the `Library` class and pass it to `Game` as needed. The `ArgumentParser.add_argument()` call has been updated to show up as an 'on/off' argument. Also fix the naming convention. According to Python's PEP 8 Style Guide, function and variable names should be lowercase with words separated by underscores (aka snake_case). The rest of this project seems to follow PEP 8, so `humanFolders` should be `human_folders`.
|
could this be achieved more simply by changing the working dir with |
This has never crossed my mind. The problem I could see with Say we use In more complicated programs I just think it is better to be explicit. |
Allow the download directory to be different from the current working directory. This makes it easier to run this as a cron job in Linux.
This PR also contains some clean ups to the
--human-foldersparameter.Remove the need for the
Gameclass to parsesys.argv. We'll store the option in theLibraryclass and pass it toGameas needed.Update the
ArgumentParser.add_argument()call to make--human-foldersa proper on/off flag.Fix the naming convention for
humanFolders. According to Python's PEP 8 Style Guide, function and variable names should be lowercase with words separated by underscores (aka snake_case). The rest of this project seems to follow PEP 8, sohumanFoldersshould behuman_folders.