Skip to content

Integrate employee directory with backend#75

Merged
Thomasbenissan merged 3 commits intomainfrom
feature/employee-directory
Apr 8, 2026
Merged

Integrate employee directory with backend#75
Thomasbenissan merged 3 commits intomainfrom
feature/employee-directory

Conversation

@Davidzongming
Copy link
Copy Markdown
Contributor

No description provided.

@Davidzongming
Copy link
Copy Markdown
Contributor Author

I run the command in readme but it still didn't pass the test, and I asked codex for this fix for this, but it says I need to change "lint": "next lint" to "lint": "eslint src prisma" in package.json. And I figured that it might be better to ask than change it.

… preserve, deduplicate DirectoryApiEmployee type, fix seed.sql duplicate buckets, restrict position edits to admins, revert Next.js 15 async patterns to match v14

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Thomasbenissan
Copy link
Copy Markdown
Collaborator

Great work on this, David! The directory PATCH endpoint and profile editing flow are solid.

A few fixes were pushed:

  • Reverted .env.sample back to placeholder values instead of hardcoded local credentials
  • Fixed tsconfig.json jsx back to "preserve" (required by Next.js 14)
  • Reverted async searchParams and cookies() patterns back to Next.js 14 sync style (project is on v14, not v15), which fixes the ESLint failures
  • Moved the duplicated DirectoryApiEmployee interface into types.ts so both EmployeeDirectory and ProfileTile import from one place
  • Fixed duplicate bucket inserts in seed.sql that would cause a primary key error when seeding
  • Restricted position field edits to admins only, since it's an auth-tier value

All CI checks (ESLint + Prettier) now pass. Nice work getting the profile persistence wired up end-to-end!

@Thomasbenissan Thomasbenissan merged commit 3d8e3f5 into main Apr 8, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants