Fix functional test suite API calls (gt-wmw) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test_dsl.py and test_power_dsl.py to use current DSL API: - Remove formula parameter from dsl() calls - Use patsy.dmatrices() to create design matrices (X, y) from formulas - Update to dsl(X, y, labeled_ind, sample_prob, model, method) signature Resolves: gt-wmw Note: Tests now call correct API but fail with optimization errors (filed gt-vr7) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix functional test suite to use current DSL API signature.
Changes
formula,predicted_var,prediction,data,sl_method,feature,family,cross_fit,sample_split,seedpatsy.dmatrices()for design matrix creationdsl(X, y, labeled_ind, sample_prob, model, method)Testing
Tests now call correct API. Note: Tests fail with optimization errors (filed gt-vr7 - separate issue).
Related
🤖 Generated with Claude Code
Note
Updates functional tests to the current matrix-based DSL API.
test_dsl.pycases to constructX/yviapatsy.dmatricesand calldsl(X, y, labeled_ind, sample_prob, model, method)(linear, logistic, and fixed-effects variants)formula,predicted_var,prediction,data,sl_method,feature,family,cross_fit,sample_split,seed) and associated setuplabeled/sample_probto usenp.ones(...)for defaultstest_power_dsl.py, updates thedsl()setup fortest_power_dsl_with_dsl_outputto the new API while keeping downstreampower_dslassertions unchangedpatsyandnumpyimports in tests and maintains shape/type assertions for result fieldsWritten by Cursor Bugbot for commit c68be11. This will update automatically on new commits. Configure here.