Conversation
JulStraus
requested changes
Nov 26, 2025
Member
JulStraus
left a comment
JulStraus
left a comment
There was a problem hiding this comment.
Looks generally good to me. There are the following three points I want to mention:
- Please update the
NEWS.mdwith the change under the headers## Unversionedand### Bugfixeswith the changes. This allows us to keep track of the changes. - I will prepare a release as well for version 0.8 once the 0.9 version is merged.
- I would like to also include #76 into the same version increase afterwards. This implies you do not have to worry about the version number, but should take a look at #76 once I have updated it.
JulStraus
deleted the
bug/input_extension_level_parameter_hydro_reservoir
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue as previously: the model looks for the level-parameter for a HydroReservoir, but it is renamed to vol. But now in the investment data checks.