Skip to content

Error message for inf growth constraints#671

Merged
tsmbland merged 5 commits intomainfrom
infinite_growth_constraints
Mar 14, 2025
Merged

Error message for inf growth constraints#671
tsmbland merged 5 commits intomainfrom
infinite_growth_constraints

Conversation

@tsmbland
Copy link
Copy Markdown
Collaborator

@tsmbland tsmbland commented Mar 12, 2025

See discussion in #668

@tsmbland tsmbland marked this pull request as ready for review March 12, 2025 19:41
Base automatically changed from optional_growth_constraints to main March 12, 2025 19:42
@tsmbland tsmbland requested a review from dalonsoa March 12, 2025 19:53
Copy link
Copy Markdown
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dalonsoa
Copy link
Copy Markdown
Collaborator

Aside from the failing tests, which I've no idea why is happening.

@tsmbland
Copy link
Copy Markdown
Collaborator Author

Aside from the failing tests, which I've no idea why is happening.

This just happens sometimes due to randomness in the test data

@tsmbland tsmbland merged commit 432e30e into main Mar 14, 2025
13 of 14 checks passed
@tsmbland tsmbland deleted the infinite_growth_constraints branch March 14, 2025 08:36
@github-project-automation github-project-automation bot moved this to ✅ Done in MUSE Mar 14, 2025
@dalonsoa
Copy link
Copy Markdown
Collaborator

It might be worth at some point to create an autoused fixture that sets the seed of the random number generator to a reasonable number, because this randomness is a pain (it always has been).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants