Narc(Betrayal Add-on) #1552
Merged
Narc(Betrayal Add-on) #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and global method to get a player's betrayal addon
There was a problem hiding this comment.
Copilot reviewed 68 out of 70 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- Resources/Lang/en_US.json: Language not supported
- Resources/roleColor.json: Language not supported
Comments suppressed due to low confidence (2)
Modules/OptionHolder.cs:106
- Changing 'RatesZeroOne' from private to public exposes internal implementation details; please confirm that this is an intentional design decision.
public enum RatesZeroOne
Patches/PlayerControlPatch.cs:1243
- [nitpick] The updated condition incorporating 'NarcManager.IsNarcAssigned()' could unintentionally grant kill button access; please verify that this logic correctly restricts access only to appropriate roles.
if ((!player.Is(Custom_Team.Impostor) || NarcManager.IsNarcAssigned()) && player.CanUseKillButton() && !playerData.IsDead)
| } | ||
|
|
||
| if (!RolesToSelect.Any()) return; | ||
| RolesToSelect = RolesToSelect.Shuffle().Shuffle().ToList(); |
There was a problem hiding this comment.
[nitpick] The double call to Shuffle() is likely redundant unless additional randomness is explicitly required; consider using a single Shuffle() call for clarity and efficiency.
Suggested change
| RolesToSelect = RolesToSelect.Shuffle().Shuffle().ToList(); | |
| RolesToSelect = RolesToSelect.Shuffle().ToList(); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
yea.i want it to be more random
if i dont do that ,when narc is in a game(all imp roles will be desync roles),the imps wont be able to kill |
resolve conflict
github-project-automation
bot
moved this from Roles
to Gamemodes
in TOHE 2.3.0 Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1520(may close #1520 after merging this one)
(Phantom basis is still an issue...)