Skip to content

fix: initialize aiohttp client only at startup #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EnokiUN merged 1 commit into from
Feb 19, 2025
Merged

fix: initialize aiohttp client only at startup #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion voltage/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class Client:

def __init__(self, *, cache_message_limit: int = 5000):
self.cache_message_limit = cache_message_limit
self.client = aiohttp.ClientSession()
self.client = None
self.http: HTTPHandler
self.ws: WebSocketHandler
self.listeners: Dict[str, Callable[..., Any]] = {}
Expand Down Expand Up @@ -252,6 +252,7 @@ async def start(self, token: str, *, bot: bool = True, banner: bool = True):
banner: :class:`bool`
Whether or not to print startup banner.
"""
self.client = aiohttp.ClientSession()
self.http = HTTPHandler(self.client, token, bot=bot)
self.cache = CacheHandler(self.http, self.loop, self.cache_message_limit)
self.ws = WebSocketHandler(self.client, self.http, self.cache, token, self.dispatch, self.raw_dispatch)
Expand Down
Loading