Open
Conversation
| - [pg_upgrade](pg_upgrade_arguments) | ||
|
|
||
| ## Other tools affected by TDE | ||
| When TDE is enabled, data load using EDB*Loader shall not invoked with `DIRECT=TRUE` option. |
Contributor
There was a problem hiding this comment.
We try to use active voice when possible. Is this an action taken by the user? If yes, maybe something like this would be a bit better:
Suggested change
| When TDE is enabled, data load using EDB*Loader shall not invoked with `DIRECT=TRUE` option. | |
| When TDE is enabled, don't use the `DIRECT=TRUE` option when loading data with EDB*Loader. |
Contributor
Author
There was a problem hiding this comment.
Hi,
Since I am not sure if I'm authorized to commit directly, let me leave a comment instead.
Yes, I agree to your change. Please go ahead to commit your change, as long as your team think it's ok.
Kind Regards,
Yuki Tei
Contributor
|
Thanksa as always @yuki-tei ! I left you one style suggestion, if you can take a look please 🙏 In the meantime, I will ask someone from the EPAS team to perform a technical review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Greetings. Hope you are doing well and healthy.
What Changed?
This same issue is found initially in EPAS15 but still exists in EPAS18.
Since its impact is huge, note shall be described in this page. Also, this change should be reflected into all affected versions:
15~18
Hope you can take a look.
Kind Regards,
Yuki Tei