Adding leader ban registry module in supra framework#290
Merged
dhaval-supraoracles merged 16 commits intodevfrom Feb 13, 2026
Merged
Adding leader ban registry module in supra framework#290dhaval-supraoracles merged 16 commits intodevfrom
dhaval-supraoracles merged 16 commits intodevfrom
Conversation
isaacdoidge
reviewed
Sep 22, 2025
isaacdoidge
left a comment
isaacdoidge
left a comment
There was a problem hiding this comment.
A good start, the config pattern is nice. There's still quite a bit to do in the registry itself though. If you haven't already read the Rust code thoroughly then please do so.
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
reviewed
Oct 2, 2025
isaacdoidge
left a comment
isaacdoidge
left a comment
There was a problem hiding this comment.
Looking good! A few more things to adjust though.
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
reviewed
Oct 3, 2025
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
reviewed
Oct 6, 2025
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
reviewed
Oct 20, 2025
isaacdoidge
left a comment
isaacdoidge
left a comment
There was a problem hiding this comment.
Looks good, but please extend the e2e test. It should cover more functionality.
aptos-move/framework/supra-framework/tests/test_leader_ban_registry.move
Outdated
Show resolved
Hide resolved
…eat/leader_ban_registry
dhaval-supraoracles
changed the title
isaacdoidge
reviewed
Oct 24, 2025
isaacdoidge
left a comment
isaacdoidge
left a comment
There was a problem hiding this comment.
Nice work! Just a couple more things to address.
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
reviewed
Feb 5, 2026
isaacdoidge
left a comment
isaacdoidge
left a comment
There was a problem hiding this comment.
Looks good! Nearly there but I'd like to adjust a couple more things now that we've added probation. I've also elaborated on a lot of the docs to provide more context.
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/configs/leader_ban_registry_config.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
aptos-move/framework/supra-framework/sources/leader_ban_registry.move
Outdated
Show resolved
Hide resolved
isaacdoidge
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.