Includes smart contracts, libraries, scripts and tests required by automation registry by udityadav-supraoracles · Pull Request #5 · Entropy-Foundation/revm

udityadav-supraoracles · 2025-12-10T05:56:16Z

This PR includes smart contracts, libraries, scripts and tests required by automation registry related to Entropy-Foundation/smr-moonshot#2523

aregng

First round of comments.

solidity/supra_contracts/src/AutomationController.sol

aregng · 2025-12-16T08:11:29Z

solidity/supra_contracts/src/AutomationController.sol

+    /// Otherwise suspention is postponed until the end of the transition state.
+    /// Nothing will be done if automation cycle was already suspended, i.e. in READY state.
+    /// If native automation feature is enabled and automation lifecycle has been in READY state, then lifecycle is restarted.
+    function onNewCycle() public {


On Move Automation side as chain feature flags where applied from epoch to epoch, the feature suspension was done in the expected natural way by implementing and calling on_new_epoch function during chain reconfiguration which was causing epoch-change as well.

With Evm Automation we do not have this option available. So I think feature total suspension should be rather immediate action run by governance.
In that case this function should be updated to be guarded by onlyOwner and also can be named as toggleAutomationFeature(bool enable)

What would be the use of bool enable argument? We already have functions to enable/disable automation. How this function would be different?

solidity/supra_contracts/src/AutomationController.sol

aregng · 2025-12-16T08:34:43Z

solidity/supra_contracts/src/AutomationController.sol

What is the main reason of having controller and registry separate.

Ethereum contracts have size limit of 24KB. The idea was to avoid exceeding the size limit by bifurcating the contracts.

solidity/supra_contracts/src/AutomationRegistry.sol

…e state -created bash script for deployment and interacting to registry contracts

variable name fixes

-added priority and task type in parameters -updated test cases

…omationCore updated scripts

solidity/supra_contracts/src/LibRegistry.sol

aregng · 2026-01-28T11:54:39Z

solidity/supra_contracts/src/LibRegistry.sol

+
+    /// @notice Tracks per-cycle automation state and task indexes.
+    struct RegistryState {
+        uint256 cycleLockedFees;


cycleLockedFees is not used in scope of automation registry directly its value is mainly used by AutomationCore. Besides it will be more appropriate to keep billing related information together, so my suggestion here will be to have cycleLockedFees and totalDepositedAutomationFees together and maybe part of the AutomationCore

-gas optimization

aregng · 2026-02-09T10:10:37Z

solidity/supra_contracts/src/AutomationController.sol

+
+    /// @notice Checks the cycle end and emit an event on it. Does nothing if SUPRA_NATIVE_AUTOMATION or SUPRA_AUTOMATION_V2 is disabled.
+    function monitorCycleEnd() external {
+        if (tx.origin != IAutomationCore(automationCore).getVmSigner()) { revert CallerNotVmSigner(); }


I can see that vm Signer is not utilized by AutomationCore, so it can be property of the controller property instead.

solidity/supra_contracts/src/AutomationController.sol

aregng · 2026-02-09T10:26:31Z

solidity/supra_contracts/src/AutomationController.sol

+                        (_taskIndex, _lockedFeeForNextCycle)
+                    )
+                );
+                require(unlocked, UnlockLockedDepositFailed());


As this is happening in scope of system transaction (AutomationRecord) execution, if unlock fails we do not fail the transaction, we simply emit an error only. Error will be addressed later by other means.

aregng · 2026-02-09T11:32:41Z

solidity/supra_contracts/src/AutomationController.sol

+    using LibController for *;
+
+    /// @dev State variables
+    LibController.AutomationCycleInfo cycleInfo;


Currently AutomationCycleInfo does not only hold only cycle related info, it also hold automation-feature flag, so my suggestion would be to rename AutomationCycleInfo to AutomationControllerState which will include automation_feature_flag and AutomationCycleDetails/Info

aregng · 2026-02-09T11:38:44Z

solidity/supra_contracts/src/AutomationCore.sol

+
+    /// @notice Function to ensure that AutomationController contract is the caller.
+    function onlyController() private view {
+        if(msg.sender != regConfig.automationController()) { revert CallerNotController(); }


There are some functions that are guarded by this function and only call internal function.
Will having this condition extended to support sender as controller or this will help to avoid simple function re-directions and contract size reduction.
e.g

/// @notice Internally calls _calculateTaskFee, reverts if caller is not AutomationController. function calculateTaskFee( CommonUtils.TaskState _state, uint64 _expiryTime, uint128 _maxGasAmount, uint64 _potentialFeeTimeframe, uint64 _currentTime, uint128 _automationFeePerSec ) external view returns (uint128) { onlyController(); return _calculateTaskFee( _state, _expiryTime, _maxGasAmount, _potentialFeeTimeframe, _currentTime, _automationFeePerSec ); }

instead _calculateTaskFee can be a public function and can be called both by this and controller contract

aregng · 2026-02-09T11:48:30Z

solidity/supra_contracts/src/AutomationCore.sol

+    function safeFeeRefund(
+        uint64 _taskIndex,
+        address _taskOwner,
+        uint256 _cycleLockedFees,


Referring this fix :Entropy-Foundation/aptos-core#329
refund amount can differ from the amount that needs to be unlocked when task is stopped.
Please updated the logic here according to the fix in move-automation.

solidity/supra_contracts/src/AutomationCore.sol

aregng · 2026-02-09T11:50:47Z

solidity/supra_contracts/src/AutomationCore.sol

+            regConfig.setGasCommittedForNextCycle(gasCommitted);
+        } else {
+            regConfig.setSysGasCommittedForNextCycle(gasCommitted);
+        } 


this function can also include deposit-fees update if task is UST and registration passed validation and to avoid having incTotalDepositedAutomationFees function.

aregng · 2026-02-09T12:01:19Z

solidity/supra_contracts/src/AutomationRegistry.sol

+    function register(
+        bytes memory _payloadTx,
+        uint64 _expiryTime,
+        bytes32 _txHash,


_txHash should not be as input, as user does not now it util txn is constructed.
There is a precompile implemented in revm-supra version which helps to retrieve it.
Example code:

contract TxHashReader { address public constant TX_HASH_PRECOMPILE = 0x0000000000000000000000000000000053555001; /// Read tx hash via precompile. Reverts if precompile missing / fails. function readTxHash() external view { (bool ok, bytes memory out) = TX_HASH_PRECOMPILE.staticcall(""); require(ok, "txhash precompile call failed"); require(out.length == 32, "txhash bad len"); } }

Could you please share the exact function signature to call on the precompile? or a link to relevant code?

aregng · 2026-02-09T12:01:56Z

solidity/supra_contracts/src/AutomationRegistry.sol

+    function registerSystemTask(
+        bytes memory _payloadTx,
+        uint64 _expiryTime,
+        bytes32 _txHash,


the same here.

solidity/supra_contracts/src/AutomationRegistry.sol

-removed access control for external view functions -updated lockedFeeForNextCycle to depositFee

udityadav-supraoracles self-assigned this Dec 10, 2025

udityadav-supraoracles requested review from aregng and sjoshisupra December 10, 2025 05:57

aregng mentioned this pull request Dec 15, 2025

Multisignature Wallet #8

Merged

aregng reviewed Dec 16, 2025

View reviewed changes

udityadav-supraoracles and others added 5 commits December 16, 2025 21:43

added smart contracts, libraries for automation registry

270f976

added test cases for registry and controller smart contract

7a6c635

fixed variable naming, replaced modifier with pvt function

d913adf

-created script to deploy automation registry contracts and initialis…

b7981a8

…e state -created bash script for deployment and interacting to registry contracts

Moved automation registry implementation to supra_contracts

11d5782

aregng force-pushed the feature/automation_registry branch from 0bcdd7d to 11d5782 Compare December 16, 2025 19:52

aregng changed the base branch from feature/evm_automation to feature/blockmeta December 16, 2025 20:14

udityadav-supraoracles added 5 commits December 17, 2025 12:40

Merge branch 'feature/blockmeta' into feature/automation_registry

8e4bff9

removed blockmeta address from controller

f19c25f

variable name fixes

-added value in payload

2cd7a8d

-added priority and task type in parameters -updated test cases

added access list in payload

16ce914

fixes for enabling/disbaling automation

261b221

udityadav-supraoracles requested a review from aregng December 23, 2025 12:50

udityadav-supraoracles added 8 commits December 31, 2025 14:44

fixed test cases involving automation disable

6bc8d43

renamed CommonUtils to LibCommonUtils

a5b09a0

renamed LibCommonUtils to CommonUtils

f61f923

Merge branch 'feature/blockmeta' into feature/automation_registry

dcae097

fixed test cases

e0a69f2

separated the config and deposit logic from AutomationRegistry to Aut…

d6a9259

…omationCore updated scripts

fixed test cases

0606947

updated scripts

9289865

aregng changed the base branch from feature/blockmeta to feature/evm_automation January 22, 2026 08:55

aregng marked this pull request as ready for review January 22, 2026 08:55

aregng and others added 2 commits January 22, 2026 12:57

Merge branch 'feature/evm_automation' into feature/automation_registry

5631351

updated scripts and README

41a2217

udityadav-supraoracles added 5 commits January 23, 2026 11:03

removed coldWallet

87bd13d

fixed validation to check if caller is AutomationCore

2342e98

fixed refundTaskFees and added test cases for AutomationController

0498938

Merge branch 'feature/evm_automation' into feature/automation_registry

7a34a1e

updated script and fixed bugs

9ee322c

aregng reviewed Jan 29, 2026

View reviewed changes

udityadav-supraoracles added 3 commits February 2, 2026 16:06

updated storage layout and implemented relevant changes for it

d154b68

moved cycle info in AutomationCore

bd92be5

updated test cases

b29cd48

udityadav-supraoracles requested a review from aregng February 3, 2026 12:14

udityadav-supraoracles and others added 3 commits February 4, 2026 15:14

moved cycleInfo to AutomationController

75db172

-added view funcitons for cycle details

79eac73

-gas optimization

Small cosmentic changes after review

4fdf9ce

aregng reviewed Feb 9, 2026

View reviewed changes

solidity/supra_contracts/src/AutomationRegistry.sol Outdated Show resolved Hide resolved

udityadav-supraoracles added 4 commits February 10, 2026 14:24

-updated register function

26ca1a5

-removed access control for external view functions -updated lockedFeeForNextCycle to depositFee

updated libraries

36569bd

updated readTxHash

77fe1e2

added mockCall for readTxHash

323813b

udityadav-supraoracles merged commit c6fd701 into feature/evm_automation Feb 11, 2026

Conversation

udityadav-supraoracles commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aregng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

udityadav-supraoracles commented Dec 10, 2025 •

edited

Loading