Skip to content

add fun "emysql:as_maps/1"#155

Open
dcy wants to merge 5 commits intoEonblast:masterfrom
dcy:master
Open

add fun "emysql:as_maps/1"#155
dcy wants to merge 5 commits intoEonblast:masterfrom
dcy:master

Conversation

@dcy
Copy link

@dcy dcy commented Nov 4, 2014

Hi!
I added the fun "emysql:as_maps/1".
And the test result:
21 basics_SUITE conversion maps_empty_test < > 0.000s Ok
22 basics_SUITE conversion maps_single_test < > 0.000s Ok
23 basics_SUITE conversion maps_multi_test < > 0.000s Ok

@dcy
Copy link
Author

dcy commented Nov 6, 2014

The Travis Ci build's error because maps are not support in R16

@tnt-dev
Copy link

tnt-dev commented Nov 6, 2014

Maybe it's better to enable this function only for OTP >= 17 for compatibility?

@dcy
Copy link
Author

dcy commented Nov 6, 2014

How to enable this function only for 17?

@dcy
Copy link
Author

dcy commented Nov 18, 2014

Could you have a look at this pull request??

@tnt-dev
Copy link

tnt-dev commented Nov 18, 2014

@dcy, You can use something like

{platform_define, "^[0-9]+", maps_available} 

in rebar.config and

-ifdef(maps_available).
-export([as_maps/1]).
-endif.

in code.

@dcy
Copy link
Author

dcy commented Nov 18, 2014

"-ifdef(maps_available)." works in emysql.erl
but not works in basics_SUITE.erl

And what's the problem with The Travis CI:
The command "source $HOME/otp/17.0-rc1/activate" failed and exited with 1 during .
Your build has been stopped.

@tnt-dev
Copy link

tnt-dev commented Nov 19, 2014

And what's the problem with The Travis CI:
The command "source $HOME/otp/17.0-rc1/activate" failed and exited with 1 during .
Your build has been stopped.

Try to change otp_releases in travis.yml from

 - 17.0-rc1

to

 - 17.3
 - 17.1
 - 17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants