Open
Conversation
Author
|
The Travis Ci build's error because maps are not support in R16 |
|
Maybe it's better to enable this function only for OTP >= 17 for compatibility? |
Author
|
How to enable this function only for 17? |
Author
|
Could you have a look at this pull request?? |
|
@dcy, You can use something like {platform_define, "^[0-9]+", maps_available} in rebar.config and -ifdef(maps_available).
-export([as_maps/1]).
-endif.in code. |
Author
|
"-ifdef(maps_available)." works in emysql.erl And what's the problem with The Travis CI: |
Try to change - 17.0-rc1to - 17.3
- 17.1
- 17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I added the fun "emysql:as_maps/1".
And the test result:
21 basics_SUITE conversion maps_empty_test < > 0.000s Ok
22 basics_SUITE conversion maps_single_test < > 0.000s Ok
23 basics_SUITE conversion maps_multi_test < > 0.000s Ok