Fix #766

[horcsinbalint]

Workshop leaders and workshop administrators could not see their alumni. This was introduced by 628ea95 and missed by c253c15

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The scopeCanView method in the User model has been modified to pass alumniIncluded: true when invoking the collegist scope for users with viewSome permission. This parameter change expands the collegist filter to include alumni records before the workshop constraint is applied.

Changes

Cohort / File(s)	Summary
Query scope modification app/Models/User.php	Updated scopeCanView to pass alumniIncluded: true parameter to collegist() scope invocation for users with viewSome permission, broadening the initial filter to include alumni records

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Fix #740 #741: Implements the alumniIncluded parameter in the scopeCollegist method that this PR now utilises, making it the foundational change that enables this modification.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ecdcd2 and 094bcbe.

📒 Files selected for processing (1)

• app/Models/User.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}